Open
Conversation
Contributor
Zoybean
commented
Jan 7, 2019
- Remove clutter
- Make internal members private
- Remove overly broad throw and catch clauses
- Use consistent capitalisation
- Use consistent code formatting
* Remove redundant statements, declarations, type parameters, casts, etc * Add braces to all control flow statements * Mark methods private where possible * Simplify boolean expressions (eg `b == true`) * Replace `for(;;)` with `for(:)` where possible
* Narrow catch clauses * Ensure method names are in lowerCamelCase and classes in UpperCamelCase * Ensure variable names are in lowerCamelCase or ALLCAPS * Mark variables private where possible (ignoring variables in all caps) * Remove unused methods and variables (ignoring incomplete methods, members that are used in commented-out code, alternative sorting algorithms, and utility methods)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.